FIX Coerce enum parameters for direct target creation#2196
Open
romanlutz wants to merge 5 commits into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 52e240e9-42d4-4c91-8608-6e14d5749576
rlundeen2
reviewed
Jul 15, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 52e240e9-42d4-4c91-8608-6e14d5749576
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 52e240e9-42d4-4c91-8608-6e14d5749576
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backend target creation could bypass registry coercion for classes that forward base configuration through
**kwargs, leaving enum-valued API parameters as raw strings. The service also duplicated registry metadata lookup and coercion logic.This change keeps enum and optional-scalar coercion in the shared
Parametercontract, makes constructor derivation follow explicitly forwarded parent constructors in MRO order, and routes all backend target construction throughTargetRegistry.create_instance. OpenAI target constructors declare their forwarding behavior, so base parameters such asendpoint,model_name, andapi_keybecome first-class registry metadata while strict unknown-parameter rejection remains intact. Open-ended keyword bags that do not forward to a parent are not treated as inherited constructor parameters.Tests and Documentation
tytype checking.